Do not handle Guzzle exception - Githubissues

repat / plentymarkets-rest-client

Plentymarkets REST Client

MIT License

15 stars 14 forks source link

Do not handle Guzzle exception #13

Closed DanMan closed 4 years ago

DanMan commented 4 years ago

https://github.com/repat/plentymarkets-rest-client/blob/f6672296688024de645d8195366470bbdc21f015/src/PlentymarketsRestClient/PlentymarketsRestClient.php#L78-L83

I'd prefer to catch that exception myself so I can have some insight into what the error was. A simple false return really doesn't cut it.

repat commented 4 years ago

Sorry I totally missed this in May, will provide a fix asap

repat commented 4 years ago

@DanMan check out version 0.1.10 and https://github.com/repat/plentymarkets-rest-client/commit/515bff2ca96df03e42fe98a0e7762d7d11c5dbdc