repeekgg / browser-extension

Browser extension that enhances the FACEIT experience and adds useful features
https://repeek.gg
GNU General Public License v3.0
133 stars 58 forks source link

Matchroom update (not displaying elo gain/loss) #117

Open invisible-defects opened 2 years ago

invisible-defects commented 2 years ago

Faceit have recently changed their match lobby UI and estimated elo gain/loss isn't displayed anymore.

chrome_ZADPHPVG1Z

tunglv-1933 commented 2 years ago

@UnimaginaryUnit i fixed ASAP. https://github.com/leedrum/faceit-enhancer/raw/fix-show-elo-estimation/faceit-enhancer-fixed-show-elo-estimation.zip u can download it from the link above and load unpacked in manage extensions or https://github.com/leedrum/faceit-enhancer if u know about Reactjs

rpkaul commented 2 years ago

@tunglv-1933 after loading your zip file in chrome i am getting this error

leedrum commented 2 years ago

@rpkaul just ignore that error. btw, Faceit changes DOM so many times => I need to update code. (I have just updated) if you don't see the detail of match like this, pls visit the link above and do the steps again. Example for me

Screen Shot 2022-02-28 at 16 02 08

Thx for the feedback.

rpkaul commented 2 years ago

@leedrum i am using your fix elo branch and its working fine now <3 thank you for the update

leedrum commented 2 years ago

@invisible-defects @rpkaul i updated new code

rpkaul commented 2 years ago

@leedrum I was about to message you , because Faceit updated few thing yesterday and that broke this code again, but now its working fine. Thank you so much for your lovely work :)

rpkaul commented 2 years ago

@leedrum one more thing, your code is working fine for 5v5 ranked game but its not working for HUB Games where captains pick players after that they do map veto , if possible check that once

leedrum commented 2 years ago

@rpkaul I have not ever played the HUB game but I think it is a custom match => ELO won't be changed.

rpkaul commented 2 years ago

@leedrum if hub is verified then ELO will be effected and now days lots of players playing in HUBs bcz of fast admin support and better matchmaking and no one can smurf there also bcz hub admins verify your faceit id , also in hub you get leaderboard thing where u get money and skins too. thats why i was saying if you want or if possible then please check

rpkaul commented 2 years ago

@leedrum hey bro can add these two PR in your recent fix elo branch? https://github.com/faceit-enhancer/faceit-enhancer/pull/85 https://github.com/faceit-enhancer/faceit-enhancer/pull/93

leedrum commented 2 years ago

@rpkaul sr, I missed.

@leedrum if hub is verified then ELO will be effected and now days lots of players playing in HUBs bcz of fast admin support and better matchmaking and no one can smurf there also bcz hub admins verify your faceit id , also in hub you get leaderboard thing where u get money and skins too. thats why i was saying if you want or if possible then please check

I must have a match link to check data to modify the code. if u have, pls send it to me ASAP.

@leedrum hey bro can add these two PR in your recent fix elo branch? #85 #93

oh, I will check later at this weekend.

rpkaul commented 2 years ago

I must have a match link to check data to modify the code. if u have, pls send it to me ASAP.

MatchRoom Links- https://www.faceit.com/en/csgo/room/1-5793d788-b434-4e67-a3e4-f596faa33f3e https://www.faceit.com/en/csgo/room/1-2748fbe2-b4df-4f0b-9047-5c555882e3f0

@leedrum hey bro can add these two PR in your recent fix elo branch? #85 #93

oh, I will check later at this weekend.

Thank you 👍

rufatalv commented 2 years ago

@leedrum can u tell me how u fixed it mate? I'm beginner developer and i want to know(

leedrum commented 2 years ago

@rpkaul The matches above don't affect ELO. I tested on the real-time match and observe. It seems still OK (you can check the video below). About "Bans history", the PR above has an error (it uses an old response from Faceit). But I fixed it (check the image below). You should re-do the steps to update the extension.

https://user-images.githubusercontent.com/25102069/157849592-58e2fc2c-9456-49ff-b1a9-27e4dd68f36e.mov

leedrum commented 2 years ago

@rufatalv The problem is Faceit changed DOMs => extension can't display to the match info area anymore. I just correct the query selector. you can check my commit here

rpkaul commented 2 years ago

@leedrum idk but its not working for my HUB , leave it its working fine for ranked game so yes its good , also yes ban history is working fine thank you.

ghost commented 2 years ago

@rufatalv The problem is Faceit changed DOMs => extension can't display to the match info area anymore. I just correct the query selector. you can check my commit here

can u post link to directly load your branch, i dont know how install on firefox pls

leedrum commented 2 years ago

@popoyeLetal it is here for firefox, u can load like the steps below

  1. Open about:debugging#addons
  2. Click on Load Temporary Add-on
  3. Select the manifest.json file
leedrum commented 2 years ago

UPDATED: I fixed auto accept party invite

AlessandroKa commented 2 years ago

@leedrum Thanks for the updated version, it works great!

rpkaul commented 2 years ago

@leedrum sorry to ping you again, but this broken again can you please fix it ? also i added you on discord so i can ping you there for future

Icytreez commented 2 years ago

@leedrum not working now =( in Chrome browser

leedrum commented 2 years ago

@rpkaul @Icytreez ok, I'm on a vacation. I will check it tomorrow. @rpkaul Discord? I don't have any friend request.

leedrum commented 2 years ago

@rpkaul @Icytreez I fixed it. u guys can re-install the extension to update the latest code. Link download: Lastest extension btw, I'm going to publish an extension to chrome store. your extension will be auto-updated via ChromeStore. p/s: I mailed to @timche but I don't receive any response from him.

rpkaul commented 2 years ago

checking now , bdw i added yopu on steam kanchatory

EDIT - WORKING FINE

leedrum commented 2 years ago

Updated lastest version: https://github.com/leedrum/faceit-enhancer/blob/v2.11.8/faceit-enhancer-fixed-show-elo-estimation.zip note:

timche commented 2 years ago

@leedrum can you please add me on Discord (timche#2098)? I'd like to discuss with you the future of this project.

leedrum commented 2 years ago

@timche done, I'm waiting for you

Sn3w233 commented 2 years ago

Could you add me to I need help to fix the match rooms Sn3w#9193

leedrum commented 2 years ago

@Sn3w233 done, pls check. btw, I'm working, so I may not reply immediately