search

repetier / Repetier-Firmware

Firmware for Arduino based RepRap 3D printer.
815 stars 734 forks source link

GUI - SD Menu scroll bar #1051

Closed AbsoluteCatalyst closed 3 years ago

AbsoluteCatalyst commented 3 years ago

Forgot to upload this tiny gui addition to help with large folders. Only shows up for U8G2's. A thin simplish scrollbar appears at the right of the screen while the rows change. It disappears quickly after we stop moving to avoid blocking any important text.

Made for the SD menus, but coincidentally works for all/any menus as well. I only added them to the sd menu.

GUI::showScrollbar(GUIAction& action) <- auto calculates the bar based on top row, current row, length etc. Just drop before a menuEnd and the bar should appear if there's enough items on the screen.

GUI::showScrollbar(GUIAction& action, float percent, uint16_t min, uint16_t max) <- allows manual control

repetier commented 3 years ago

Cool idea. Need to check with config and tune menus how it looks. I think it could be a nice addition to see where in the menu you are.

AbsoluteCatalyst commented 3 years ago

Just came back in and tested it out now on all the menus and it seems to mesh fairly decent system wide. Yeah try it out when you get a chance. Menus such as extruder config are quite long.

( We haven't done the TMC drivers settings menu yet right? I could have sworn there was one. Weird. )

repetier commented 3 years ago

I will. In that case we can put it directly in menuEnd.

Checked it and also can't see any TMC menu also thought we hat them. Did one of us remove them with a merge involuntary? Haven't removed them on purpose in any case.

AbsoluteCatalyst commented 3 years ago

Ah, It looks like we just haven't gotten around to them. There's menus for the adjustable resolution drivers, but besides that git doesn't show anything.

repetier commented 3 years ago

We also have it for mirror so all get called. So maybe that is what we were thinking about. And it is in eeprom. Question is also how much sense does it make in menu. Nothing you would change constantly. Maybe current since some errors can change current settings.

AbsoluteCatalyst commented 3 years ago

Current was the first I thought about too. Only thing I ever change at any frequency. Stealth?

repetier commented 3 years ago

Not sure about stealth. With hybrid and homing it changes automatically as well. Also if I think about prusa there you can set it for the print so you decide loud or fast for all motors. Actually I like the hybrid thing so your speed just decides and if you want crash detection you have no choice anyway.