search

repetier / Repetier-Firmware

Firmware for Arduino based RepRap 3D printer.
812 stars 734 forks source link

class SDCard -> SdBaseFile parentFound #790

Open Nibbels opened 6 years ago

Nibbels commented 6 years ago

https://github.com/repetier/Repetier-Firmware/blob/eca23dd201e739ea49307a4be4ffcea7198c0982/src/ArduinoAVR/Repetier/Repetier.h#L1001

Hello there,

Thx for the work on the new SD-Lib. I pulled the changes and maybe found some way to save 22 Bytes of Ram.

class SDCard -> SdBaseFile parentFound;

My notepad++ cannot find any reference. And removing it gives me some free Ram. (I might be wrong here, please recheck this if you find some time for that tiny problem.)

Greetings from Stuttgart

Nibbels commented 6 years ago

Is int8_t oldMenuLevel; within ui.h bogus too?

It is there, gets set twice but never read. Yes I know, this code is old.