Closed ashy1227 closed 7 months ago
(Sorry, I didn't notice this, since I was looking at the comments)
What i would like is for the undyed circuits to be dyeable, since you would want to apply color to existing circuits. But i'm not sure it makes sense for the stone material to become concrete somehow. I also thought about whether it makes sense to completely remove the old stone circuit block, and convert them to white ones when updating? What's your thought on that?
Yea I think it makes sense to convert them... I'm not sure how to write DFUs though, and the fabric wiki is incomplete
I'll work on fixing the code style now
Alright, i can take a look if it's simple enough to convert them
Alright, i can take a look if it's simple enough to convert them
I gave up, looks like fabric api has nothing to make it easier for registering/creating datafixers for mods. Let's just keep the id for now
Oof, that stinks :/ but okay...
So then an idea I had for converting them: if you don't want to just be able to dye stone to concrete, we could add a recipe with the stone circuit in the middle and three concrete on the bottom to make a colored one
I think for consistency dyeing them directly is fine as a temporary solution, until we can migrate the stone one to concrete.
Okay, anything else before it gets merged? Maybe updating the icon/readme?
?
Oh yeah, updating the icon too makes sense
There's still the case of outputStrength, but you can also just leave it like it is now. I want to work on the update behaviour so that block updates go into the circuit directly instead of waiting for the block entity tick. In doing that the outputStrength would likely not be needed, only for the rendering. So until i work on that leaving it like it is now with the mixin would be fine.
Okay, sounds good
Yee, that should be everything
Alright, thank you so much
Added colored circuits to make it easier to differentiate what they do. You can also see the redstone going in and out of them. Also some other miscellaneous changes like: