search

replay-framework / replay

Fork of the Play1 Framework
Other
20 stars 11 forks source link

`com.google.code.findbugs:jsr305` can probably be removed #181

Open cies opened 1 year ago

cies commented 1 year ago

Since we use guava version 32.x.x.

Like here: https://github.com/playframework/playframework/commit/d6cccba611efb9c11414d30900eeecee59436cf9

cies commented 1 year ago

Guava migrated to https://mvnrepository.com/artifact/org.checkerframework/checker-qual/3.35.0 (210k where jsr305 was 12k).

Internally we use org.jetbrains:annotations (29k).

All annotations that the Kotlin compiler understands are listed here:

https://github.com/JetBrains/kotlin/blob/master/core/compiler.common.jvm/src/org/jetbrains/kotlin/load/java/JvmAnnotationNames.kt

I can make a PR replacing the use of jsr305 with whatever is chosen.

asolntsev commented 1 year ago

@cies Yes, why not. We can upgrade to whatever newer library. I don't see any reasons to prefer one of them over others.

But I personally like annotations with javax. prefix (like javax.annotation.Nullable) - just because they look like a standard. :)

cies commented 1 year ago

I was mistaken. Guava has not migrated yet. The discussion here:

https://github.com/google/guava/issues/2960

That thread is linked to by several other projects, and they usually migrate to jetbrains-annontations or checker-qual.

cies commented 1 year ago

I'd opt for snoozing this until Guava makes the switch and then follow their choice (not to add any more dependencies).

cies commented 1 month ago

Guava is still not decided. Lol.