Fix safe intelliJ hints, mostly...

replay-framework / replay

Fork of the Play1 Framework

Other

20 stars 11 forks source link

Fix safe intelliJ hints, mostly... #445

Closed cies closed 2 months ago

cies commented 2 months ago

I wanted to do this for a long time: apply some basic refactors to RePlay.

In a few places I have added comments in the Github diff to explain myself: so see them below as well, but I think they are more useful when reading the "Files changed" tab (there's more context there and you are in the "flow" I wrote them in)

EDIT: edited the text a bit to explain myself.

cies commented 2 months ago

merged in main

asolntsev commented 2 months ago

merged in main

@cies Are you sure this PR is merged to main? At least I see that status is "Closed", not "Merged". And I see warning "Closed with unmerged commits" as well...