replayio / design

Tasks for the Replay design team
1 stars 0 forks source link

[Dark] Pause line highlight should be more noticeable #34

Closed jasonLaster closed 2 years ago

jasonLaster commented 2 years ago

The pause line in dark mode is a bit too subtle. Also, not sure if the "flash" is noticeable in dark mode. image

https://discord.com/channels/779097926135054346/957390059714281482/967760989095350272

Andarist commented 2 years ago

This would definitely improve the situation - but i wonder: is there a strong argument here to avoid the scroll jump in the reported scenario?

jonbell-lot23 commented 2 years ago

Agreed. There's a key insight here:

And three implantation ideas:

  1. More noticeable flash
  2. More clear background colour
  3. Scroll jump

I'd argue the first two are less impactful than the third, and can all work together. Is there an argument against the scroll jump?

jasonLaster commented 2 years ago

re scroll jump: I think i need to see a video of the scroll jump we're referring to. If i'm understanding correctly though, the reason is that if you scroll every time you step forward or backwards it would be disruptive. Step in / out is different, but harder to differentiate from.

Andarist commented 2 years ago

Yes, scrolling at all times would be disruptive - im specifically mentioning a scenario when we cross a function boundary though. When I either jump into a new function or jump out of the existing ones. In this scenario I usually have no idea where the "target" function is and I dont expect my scroll position to be preserved because most often than not it's not preserved as very often the target function is elsewhere

gideonred commented 2 years ago

This ticket has been moved to DES-26