replayio / node

Integration of the node.js runtime with the record/replay driver
https://nodejs.org/
Other
20 stars 3 forks source link

Replay not pausing at correct position in call stack for breakpoint #81

Open nathggns opened 2 years ago

nathggns commented 2 years ago

Version

v14.17.6

Platform

Darwin Nates-MacBook-Air.local 21.4.0 Darwin Kernel Version 21.4.0: Mon Feb 21 20:36:53 PST 2022; root:xnu-8020.101.4~2/RELEASE_ARM64_T8101 x86_64

Subsystem

No response

What steps will reproduce the bug?

As a possible workaround for https://github.com/RecordReplay/node/issues/28 I used process.exit to exit my script as a desirable point. The command I used to run the recording is replay-node --exec ts-node ./src/index.ts.

How often does it reproduce? Is there a required condition?

Seemingly every time

What is the expected behavior?

Replay should pause at the specified breakpoint

What do you see instead?

Replay seems to be pausing at an unrelated breakpoint

Additional information

The replay I'm experiencing this bug on is https://app.replay.io/recording/replay-of-ts-node--2833115f-26fd-4160-8b1d-ec19f86d8d16

Replay of the bug occurring is at https://app.replay.io/recording/replay-misidentifying-where-to-pause-for-breakpoint--3668d82a-b2e6-49cd-a1cb-0ba103cdcd85

Reported on Discord at https://discord.com/channels/779097926135054346/798693728999047203/980889833998282792

Screen recording uploaded to Discord at https://discord.com/channels/779097926135054346/798693728999047203/980890518898753566

bhackett1024 commented 2 years ago

I think this is fixed by https://github.com/replayio/node/pull/85, which is included in the latest released node. If you have a chance to confirm that would be great.

gideonred commented 2 years ago

This ticket has been moved to RUN-317