Refactor existing tests

replayio / playwright-tests

Playwright harness and tests used by replay CI

BSD 3-Clause "New" or "Revised" License

14 stars 7 forks source link

Refactor existing tests #54

Closed ryanjduffy closed 3 years ago

ryanjduffy commented 3 years ago

Refactor existing tests to use smarter selectors and example helper.

[X] airbnb #32
[ ] airtable
[X] climatescape #35
[X] codesandbox #34
[X] cypress #36
[ ] discord
[X] espn #37
[X] firebugs #42
[ ] framer
[X] monaco #45
[X] notion #46
[X] nytimes #47
[X] reactcharts #49
[X] reactvirtualized #50
[X] realadvisor #51
[X] reddit #55
[X] replay #60
[X] storybook #52
[X] tablecheck #53
[X] unsplash #56
[X] vscode #58
[X] whatsmyuseragent #57
[X] yelp #30

ryanjduffy commented 3 years ago

Added a PR (#63) to do some clean up. I think that'll be the last for this ticket. The remaining stories all require some form of 2FA that is impeding automation. Suggest we come back to them later on or create new issues for those individually.

cc: @jasonLaster

ryanjduffy commented 3 years ago

Closing this as done given the caveat above.