search

replayio / playwright

Replay enabled fork of the Playwright library
Apache License 2.0
4 stars 0 forks source link

Update playwright to 1.18 #7

Closed ryanjduffy closed 2 years ago

ryanjduffy commented 2 years ago

Issue

Our modified build of playwright was from 1.10 and was incompatible with @playwright/test which is a common runner for playwright.

Resolution

Notes

I also disabled a couple WebDriver protocol messages (Browser.setReducedMotion and Browser.setForcedColors) that don't seem to be supported by Replay. Would be better to comment those out in source before the build but I did include that change in 8893e1b94c83cb644482e5371e05c33d769d1a92 which includes all of our customizations.

ryanjduffy commented 2 years ago

We don't have docs yet. I think we'll want to create a proper fork of playwright with our customizations onto which we can merge upstream. I'll add a CONTRIBUTING.md to this PR to document my steps for this time so we can continue to refresh as needed.