replaysMike / Binner

Open source parts inventory system for makers, electronics hobby, and professional engineers
https://binner.io
GNU General Public License v3.0
268 stars 41 forks source link

Error changing quantity in Inventory #133

Closed TWM617 closed 1 year ago

TWM617 commented 1 year ago

I changed the quantity of a part in inventory by typing in a number then hit enter. I got the following error message:

Ashampoo_Snap_Thursday, March 23, 2023_11h06m09s_004_

replaysMike commented 1 year ago

Well that’s a neat one, not sure why that would have made any requests to print but I will look into it in more detail in the morning

replaysMike commented 1 year ago

I'm still trying to track this one down, if you see it again ping me here.

TWM617 commented 1 year ago

The problem is easily reproduceable and it appears that the Print button has form keypress focus so that an Enter button press on most fields calls the print function.

replaysMike commented 1 year ago

I completely misread your original cause here, my fault. I'll fix this today. Ideally I think, pressing enter should only submit the form and not trigger any other components as it's sometimes difficult to know what has focus.

replaysMike commented 1 year ago

figured it out, it was a little devil of a bug in react. You have a real knack for finding these (which I'm happy about!) :)

TWM617 commented 1 year ago

Glad to hear you squashed it! I have been in the computer biz for 43 years and started my career as a repair tech of just about every hardware development product that Intel made at the time. It made me rather persistent at finding and troubleshooting problems. You can count on me finding more…!

Tim


From: Michael Brown @.> Sent: Wednesday, March 29, 2023 5:53:54 PM To: replaysMike/Binner @.> Cc: TWM617 @.>; Author @.> Subject: Re: [replaysMike/Binner] Error changing quantity in Inventory (Issue #133)

figured it out, it was a little devil of a bug in react. You have a real knack for finding these (which I'm happy about!) :)

— Reply to this email directly, view it on GitHubhttps://github.com/replaysMike/Binner/issues/133#issuecomment-1489531757, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY2JAWMAXMMKOO2ZE3SX7GDW6TKSFANCNFSM6AAAAAAWFR5LZY. You are receiving this because you authored the thread.Message ID: @.***>