search

replaysMike / Binner

Open source parts inventory system for makers, electronics hobby, and professional engineers
https://binner.io
GNU General Public License v3.0
268 stars 41 forks source link

digikey parts links #151

Closed interbiznw closed 1 year ago

interbiznw commented 1 year ago

seems the digikey parts links are hardcoded to digikey.ca, might be good to add option in settings?

image

replaysMike commented 1 year ago

are you using Binner.io or the open source installation?

If you aren't using your own DigiKey api key, it's possible DigiKey is region locking our API account since it was created in Canada, so all URL's come up as .ca.

According to DigiKey's api, they do provide support to override the default region/locale/currency so I should look at adding support for that.

interbiznw commented 1 year ago

are you using Binner.io or the open source installation?

Open source local linux install with my own digikey api key but its still going to digikey.ca

TWM617 commented 1 year ago

I too am in the U.S. and the "Visit" link takes me to a ".ca" Digikey site. Presumably it returns all prices in Canadian dollars...? If so then I need to rescan all of my inventory.

replaysMike commented 1 year ago

Yes I'm going to fix this in the next release, and make it an option. I can add the ability to update that information so you don't need to rescan anything

TWM617 commented 1 year ago

Michael,

Rescanning is not a really big deal. Don’t add anything just for me. Not sure if others are affected.

Tim

From: Michael Brown @.> Sent: Tuesday, April 11, 2023 11:56:12 AM To: replaysMike/Binner @.> Cc: TWM617 @.>; Comment @.> Subject: Re: [replaysMike/Binner] digikey parts links (Issue #151)

Yes I'm going to fix this in the next release, and make it an option. I can add the ability to update that information so you don't need to rescan anything

— Reply to this email directly, view it on GitHubhttps://github.com/replaysMike/Binner/issues/151#issuecomment-1503933812, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY2JAWMFMZ7LZB4V7QZ23J3XAWSMZANCNFSM6AAAAAAWV6EQ44. You are receiving this because you commented.Message ID: @.***>

replaysMike commented 1 year ago

I can picture this as a useful tool, as I don't currently have anything for keeping values up to date. It could be automated, but I don't want to overwrite values someone may have entered manually.

replaysMike commented 1 year ago

This is now fixed and will appear in v.2.3.7