replaysMike / Binner

Open source parts inventory system for makers, electronics hobby, and professional engineers
https://binner.io
GNU General Public License v3.0
268 stars 41 forks source link

[Feature Request]: use own certificate and/or disable ssl #227

Open cfrepak opened 1 year ago

cfrepak commented 1 year ago

Binner version

2.6.0

Operating System

Debian 12

Describe the bug and the steps to reproduce it

I am having problems installing Binner on our network because of the built-in self-signed certificate. It is not possible to allow trusted access through the browser this way. A network wide installation of the certificate is impossible for obvious reasons. In addition, the self-signed certificate prevents the use of a reverse proxy, which is the preferred method for neglecting the port at the end of the URL, as well as leaving the general configuration of the web host to a web server.

I would like to be able to either include my own (CA signed) certificates, or even better disable SSL altogether.

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

None

replaysMike commented 5 months ago

I'll take a look at this and see if I can come up with a solution. Self-signed certs are the norm for this kind of thing, but I agree if you want to integrate it into a corporate network for multiple users it would be nice to allow setting of an alternate SSL certificate as well as the option to disable.

I'll look at this for v2.6.4 next week.

joeyhagedorn commented 2 months ago

Thanks for looking into this! I also would love to specify a custom SSL certificate. I use Let’s Encrypt to get valid SSL certificates for other services I run, which is increasingly commonplace. It’s pretty easy to setup a script that uses the ACME protocol to renew certs automatically.

replaysMike commented 2 months ago

Agreed, this was on the backburner since certificates weren't working on unix environments. Certificates are always a pain on windows, I'll try to schedule this shortly.

Neustradamus commented 1 month ago

Yes it is important.