Make commands better - Githubissues

repldex / Repldex

https://repldex.com

MIT License

21 stars 10 forks source link

Make commands better #163

Closed mat-1 closed 3 years ago

mat-1 commented 3 years ago

The interaction when doing handle in bot.ts is now a lot easier to use, and it comes with TypeScript typings.

selectdev commented 3 years ago

I disapprove, you didn't add params to any of the functions

mat-1 commented 3 years ago

I disapprove, you didn't add params to any of the functions

Can you elaborate on this? Are you referring to a different unrelated part of the code?

selectdev commented 3 years ago

I disapprove, you didn't add params to any of the functions

Can you elaborate on this? Are you referring to a different unrelated part of the code?

Each function that takes a value should have a comment added before the function that looks like `/**

@param String name - the entry name`
Information about this function */`

selectdev commented 3 years ago

Code Blocks suck

stjet commented 3 years ago

Select, this is not necessary as we are not going to auto generate docs (those are internal functions), and anyone can figure out the parameters by looking at them because this is typescript. @selectthegang

selectdev commented 3 years ago

Yeah, but either way we should have params because it helps both Replit and VScode code intelligence. Mat has replied to my message on the Repldex Discord saying that he might add it (https://discord.com/channels/662039537479843850/662039537932959754/911839737650761769)