search

replete-repl / replete-ios

ClojureScript REPL iOS app
Eclipse Public License 1.0
396 stars 25 forks source link

Upgrade to iOS 10 #102

Open dotemacs opened 7 years ago

dotemacs commented 7 years ago

Started this issue in order not to hijack the issue #81

To update to iOS 10 it's not a big deal, you just have to select what OS version to target.

However you'll get these two warnings (but despite them, the app will build run in the simulator):

...replete/Replete/AppDelegate.m:243:52: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

and

...replete/Replete/AppDelegate.m:264:45: 'applicationFrame' is deprecated: first deprecated in iOS 9.0 - Use -[UIScreen bounds]

Fixing those issues is not that hard, but I just didn't get around to it yet.

mfikes commented 7 years ago

That's cool. I wonder if we even need to upgrade—as it stands now Replete works on iOS 8–10.

Of course, as you mention, #81 and Ejecta might force the issue.

mfikes commented 7 years ago

This will be taken care of via a change in the pod file as in https://github.com/sherbondy/replete/commit/91e232909c912cab2123c4a4137c7c658b478edb#diff-4a25b996826623c4a3a4910f47f10c30R2