search

replete-repl / replete-ios

ClojureScript REPL iOS app
Eclipse Public License 1.0
396 stars 25 forks source link

Move Replete iOS codebase up to Swift 4 #114

Closed hlprmnky closed 6 years ago

hlprmnky commented 6 years ago

Swift 4!

Code compiles with only one warning, namely that the app iconset needs a 1024x1024 store image size, which I do not presume to try and create on my own. :)

Input scrolling is fixed, see attached .gif. Tested in simulator on iPhone SE, iPad Pro 12.9", and a few sizes of device in between on iOS 10 and 11.

Commits are split out into "Compiles with Swift 3 conversion on old Xcode", "Compiles with Swift 3 in Xcode 9 + input scroll fix", "Compiles with Swift 4 conversion", just in case there's some reason to not go all the way into The Future™.

text_input_scroll_fixed_iphone_se

hlprmnky commented 6 years ago

Also should resolve #105 and #113 in case that isn't clear from the title and submit commentary. 😇

mfikes commented 6 years ago

Awesome!