repletsin5 / VanillaIcecreamFix

Other
1 stars 0 forks source link

Incompatible with Enchant Tweaker #10

Closed zkkei closed 1 year ago

zkkei commented 1 year ago

Enchant Tweaker is conflicting with VanillaIcecreamFix.

Stacktrace

org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("CONSTANT") on net/minecraft/class_471::notTooExpensiveClient with priority 1000 cannot inject into net/minecraft/class_471::method_2388(Lnet/minecraft/class_332;II)V merged by me.replet.client.other.AnvilLevelMaxMixin with priority 1000 [PREINJECT Applicator Phase -> enchanttweaker.mixins.json:client.anvil.NotTooExpensiveMixin from mod enchanttweaker -> Prepare Injections ->  -> constant$bdm000$enchanttweaker$notTooExpensiveClient(I)I -> Prepare]
    at org.spongepowered.asm.mixin.injection.code.Injector.findTargetNodes(Injector.java:305)
    at org.spongepowered.asm.mixin.injection.code.Injector.find(Injector.java:240)
    at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.prepare(InjectionInfo.java:421)
    at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1337)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1053)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
    at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
    at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
    at net.minecraft.class_3929.<clinit>(class_3929.java:90)
    at net.minecraft.class_634.method_17587(class_634.java:1197)
    at net.minecraft.class_3944.method_17591(class_3944.java:37)
    at net.minecraft.class_3944.method_11054(class_3944.java:11)
    at net.minecraft.class_2600.method_11072(class_2600.java:22)
    at net.minecraft.class_1255.method_18859(class_1255.java:156)
    at net.minecraft.class_4093.method_18859(class_4093.java:23)
    at net.minecraft.class_1255.method_16075(class_1255.java:130)
    at net.minecraft.class_1255.method_5383(class_1255.java:115)
    at net.minecraft.class_310.method_1523(class_310.java:1175)
    at net.minecraft.class_310.method_1514(class_310.java:802)
    at net.minecraft.client.main.Main.main(Main.java:250)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Mod list

- advanced_runtime_resource_pack 0.6.7 via enhancedblockentities
- advancementplaques 1.4.11
- allstackable v2.0.0-1.20.1
- alwaysawitherskull 3.0
- architectury 9.1.12
- armor_visibility 9.0.1+1.20.1
- ash_api 3.0.2+1.20.1
- balm-fabric 7.0.7
- better_totem_of_undying 1.20.1-1.0.1
- betterbeaconplacement 3.1
- betterspawnercontrol 4.2
- betterthanmending 1.3.0
- bettertrims 1.1.1
- blur 3.1.0
- c2me 0.2.0+alpha.10.96
- c2me-base 0.2.0+alpha.10.96 via c2me
- c2me-client-uncapvd 0.2.0+alpha.10.96 via c2me
- c2me-fixes-chunkio-threading-issues 0.2.0+alpha.10.96 via c2me
- c2me-fixes-general-threading-issues 0.2.0+alpha.10.96 via c2me
- c2me-fixes-worldgen-threading-issues 0.2.0+alpha.10.96 via c2me
- c2me-fixes-worldgen-vanilla-bugs 0.2.0+alpha.10.96 via c2me
- c2me-notickvd 0.2.0+alpha.10.96 via c2me
- c2me-opts-allocs 0.2.0+alpha.10.96 via c2me
- c2me-opts-chunk-access 0.2.0+alpha.10.96 via c2me
- c2me-opts-chunkio 0.2.0+alpha.10.96 via c2me
- c2me-opts-math 0.2.0+alpha.10.96 via c2me
- c2me-opts-scheduling 0.2.0+alpha.10.96 via c2me
- c2me-opts-worldgen-general 0.2.0+alpha.10.96 via c2me
- c2me-opts-worldgen-vanilla 0.2.0+alpha.10.96 via c2me
- c2me-rewrites-chunk-serializer 0.2.0+alpha.10.96 via c2me
- c2me-rewrites-chunkio 0.2.0+alpha.10.96 via c2me
- c2me-server-utils 0.2.0+alpha.10.96 via c2me
- c2me-threading-chunkio 0.2.0+alpha.10.96 via c2me
- c2me-threading-lighting 0.2.0+alpha.10.96 via c2me
- c2me-threading-worldgen 0.2.0+alpha.10.96 via c2me
- caffeineconfig 1.3.0+1.17 via sodium-extra
- cardinal-components-base 5.2.1 via better_totem_of_undying
- cardinal-components-entity 5.2.1 via better_totem_of_undying
- charmofundying 6.4.2+1.20.1
- clickthrough 1.20-fabric0.83.0-0.4.1
- cloth-basic-math 0.6.1 via cloth-config
- cloth-config 11.1.106
- cobble_tostoneviceversa_mr 1.0
- collective 6.65
- com_akuleshov7_ktoml-core-jvm 0.4.1 via zoomify
- com_electronwill_night-config_core 3.6.6 via couplings
- com_electronwill_night-config_toml 3.6.6 via couplings
- com_github_llamalad7_mixinextras 0.2.0-beta.9 via dynamictrim
- com_ibm_async_asyncutil 0.1.0 via c2me
- com_moandjiezana_toml_toml4j 0.7.2 via dynamicfps
- com_twelvemonkeys_common_common-image 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- com_twelvemonkeys_common_common-io 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- com_twelvemonkeys_common_common-lang 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- com_twelvemonkeys_imageio_imageio-core 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- com_twelvemonkeys_imageio_imageio-metadata 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- com_twelvemonkeys_imageio_imageio-webp 3.10.0-SNAPSHOT via yet_another_config_lib_v3
- conditional-mixin 0.3.2 via elytratrims
- config2brigadier 1.2.5 via simplevillagers
- continuity 3.0.0-beta.3+1.20.1
- couplings 1.9.5+1.20
- crowdin-translate 1.4+1.19.3 via clickthrough
- cull-less-leaves 1.2.0
- dark-loading-screen 1.6.14
- dev_isxander_settxi_settxi-core 2.10.6 via zoomify
- dev_isxander_settxi_settxi-kotlinx-serialization 2.10.6 via zoomify
- dynamiccrosshair 7.0.4+1.20
- dynamicfps 2.4.0
- dynamictrim 1.1.0
- easyelytratakeoff 4.0
- elytraslot 6.3.0+1.20.1
- elytratrims 1.2.1
- enchanttweaker 1.4.3+mc1.20-1.20.1
- enhancedblockentities 0.9+1.20
- entityculling 1.6.2-mc1.20
- exordium 1.1.3.1-mc1.20.1
- expanded_armor_enchanting 1.0.6
- expanded_trident_enchanting 1.0.7
- expanded_weapon_enchanting 1.0.6
- fabric-api 0.86.1+1.20.1
- fabric-api-base 0.4.30+7abfd51577 via fabric-api
- fabric-api-lookup-api-v1 1.6.35+4d8536c977 via fabric-api
- fabric-biome-api-v1 13.0.10+b3afc78b77 via fabric-api
- fabric-block-api-v1 1.0.9+e022e5d177 via fabric-api
- fabric-blockrenderlayer-v1 1.1.40+b3afc78b77 via fabric-api
- fabric-client-tags-api-v1 1.1.1+97bb207577 via fabric-api
- fabric-command-api-v1 1.2.33+f71b366f77 via fabric-api
- fabric-command-api-v2 2.2.12+b3afc78b77 via fabric-api
- fabric-commands-v0 0.2.50+df3654b377 via fabric-api
- fabric-containers-v0 0.1.62+df3654b377 via fabric-api
- fabric-content-registries-v0 4.0.9+b3afc78b77 via fabric-api
- fabric-convention-tags-v1 1.5.4+a1a980da77 via fabric-api
- fabric-crash-report-info-v1 0.2.18+aeb40ebe77 via fabric-api
- fabric-data-generation-api-v1 12.2.1+1e61dba177 via fabric-api
- fabric-dimensions-v1 2.1.52+b3afc78b77 via fabric-api
- fabric-entity-events-v1 1.5.22+b3afc78b77 via fabric-api
- fabric-events-interaction-v0 0.6.1+e91849a877 via fabric-api
- fabric-events-lifecycle-v0 0.2.62+df3654b377 via fabric-api
- fabric-game-rule-api-v1 1.0.38+b04edc7a77 via fabric-api
- fabric-item-api-v1 2.1.27+b3afc78b77 via fabric-api
- fabric-item-group-api-v1 4.0.10+23d9108177 via fabric-api
- fabric-key-binding-api-v1 1.0.36+fb8d95da77 via fabric-api
- fabric-keybindings-v0 0.2.34+df3654b377 via fabric-api
- fabric-language-kotlin 1.10.8+kotlin.1.9.0
- fabric-lifecycle-events-v1 2.2.21+b3afc78b77 via fabric-api
- fabric-loot-api-v2 1.1.39+b3afc78b77 via fabric-api
- fabric-loot-tables-v1 1.1.43+9e7660c677 via fabric-api
- fabric-message-api-v1 5.1.7+3265161977 via fabric-api
- fabric-mining-level-api-v1 2.1.49+b3afc78b77 via fabric-api
- fabric-model-loading-api-v1 1.0.2+709a987177 via fabric-api
- fabric-models-v0 0.4.1+9386d8a777 via fabric-api
- fabric-networking-api-v1 1.3.9+b3afc78b77 via fabric-api
- fabric-networking-v0 0.3.49+df3654b377 via fabric-api
- fabric-object-builder-api-v1 11.1.1+6beca84877 via fabric-api
- fabric-particles-v1 1.1.1+201a23a077 via fabric-api
- fabric-permissions-api-v0 0.1-SNAPSHOT via simplevillagers
- fabric-recipe-api-v1 1.0.19+b3afc78b77 via fabric-api
- fabric-registry-sync-v0 2.3.1+4df89eb277 via fabric-api
- fabric-renderer-api-v1 3.1.1+9386d8a777 via fabric-api
- fabric-renderer-indigo 1.4.1+9172968c77 via fabric-api
- fabric-renderer-registries-v1 3.2.45+df3654b377 via fabric-api
- fabric-rendering-data-attachment-v1 0.3.34+b3afc78b77 via fabric-api
- fabric-rendering-fluids-v1 3.0.27+b3afc78b77 via fabric-api
- fabric-rendering-v0 1.1.48+df3654b377 via fabric-api
- fabric-rendering-v1 3.0.7+b3afc78b77 via fabric-api
- fabric-resource-conditions-api-v1 2.3.5+ea08f9d877 via fabric-api
- fabric-resource-loader-v0 0.11.9+132c48c177 via fabric-api
- fabric-screen-api-v1 2.0.7+b3afc78b77 via fabric-api
- fabric-screen-handler-api-v1 1.3.28+b3afc78b77 via fabric-api
- fabric-sound-api-v1 1.0.12+b3afc78b77 via fabric-api
- fabric-transfer-api-v1 3.3.0+cdf060b277 via fabric-api
- fabric-transitive-access-wideners-v1 4.3.0+6c31357e77 via fabric-api
- fabricloader 0.14.21
- fallingtree 4.2.3
- faster_entity_animations 1.6
- fastrandom 1.3
- ferritecore 6.0.0
- firstperson 2.2.3
- flamesweeping 1.20.1-1.1
- forgeconfigapiport 8.0.0
- gbfabrictools 1.4+1.20 via clickthrough
- highspeed-rail 0.4.0+1.20.1
- iceberg 1.1.14
- immediatelyfast 1.1.27+1.20.1
- indium 1.0.23+mc1.20.1
- infinitetrading 4.0
- inventoryprofilesnext 1.10.6
- io_github_douira_glsl-transformer 2.0.0-pre13 via iris
- iris 1.6.5
- itemborders 1.2.0
- jamlib 0.6.1+1.20.x
- java 17
- kirin 1.15.0 via presencefootsteps
- kleeslabs 15.0.0
- lambdynlights 2.3.1+1.20.1
- lazydfu 0.1.3
- legendarytooltips 1.4.4
- libipn 3.0.2
- lithium 0.11.2
- memoryleakfix 1.1.1
- midnightlib 1.4.1 via blur
- minecraft 1.20.1
- mixin-conflict-helper 1.2.0
- modelfix 1.14
- modernfix 5.4.2+mc1.20.1
- modmenu 7.2.1
- net_lenni0451_reflect 1.2.1 via immediatelyfast
- net_objecthunter_exp4j 0.4.8 via c2me
- no-lan-cheating 1.5.0+1.20.1
- notenoughanimations 1.6.4
- org_anarres_jcpp 1.4.14 via iris
- org_antlr_antlr4-runtime 4.11.1 via iris
- org_jetbrains_kotlin_kotlin-reflect 1.9.0 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib 1.9.0 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.9.0 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.9.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_atomicfu-jvm 0.21.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.7.2 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.7.2 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.5.1 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.5.1 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.5.1 via fabric-language-kotlin
- org_threadly_threadly 7.0 via c2me
- packet_tweaker 0.4.0+1.19.4 via polymer-common
- playlist 1.3.0
- polymer-common 0.5.0-rc.3+1.20 via simplevillagers
- polymer-core 0.5.0-rc.3+1.20 via simplevillagers
- polymer-networking 0.5.0-rc.3+1.20 via polymer-core
- polymer-registry-sync-manipulator 0.5.0-rc.3+1.20 via polymer-core
- polymer-resource-pack 0.5.0-rc.3+1.20 via simplevillagers
- presencefootsteps 1.9.0
- pride 1.2.0+1.19.4 via lambdynlights
- prism 1.0.5
- reeses-sodium-options 1.6.4+mc1.20.1-build.94
- rightclickharvest 3.2.2+1.19.x-1.20.1-fabric
- satin 1.13.0 via blur
- server_translations_api 2.0.0-beta.2+1.19.4-pre2 via simplevillagers
- sgui 1.2.2+1.20 via simplevillagers
- shulkerboxtooltip 4.0.4+1.20.1
- simplevillagers 1.4.5
- sodium 0.5.0
- sodium-extra 0.5.0+mc1.20.1-build.111
- sound_physics_remastered 1.20.1-1.1.2
- spark 1.10.42
- spectrelib 0.13.13+1.20.1 via charmofundying
- spruceui 5.0.0+1.20 via enhancedblockentities
- stacked_trims 1.1.0
- starlight 1.1.2+fabric.dbc156f
- taxfreelevels 1.3.3
- tlskincape 1.32
- trimmable_tools 1.0.4
- trinkets 3.7.0
- vanillafix 1.1.7-beta
- videotape 1.1.0
- voicechat 1.20.1-2.4.20
- xaerominimap 23.6.0
- yaclx 1.3+1.20 via dynamiccrosshair
- yet_another_config_lib_v3 3.1.0+1.20
- zombify 0.1.4
- zoomify 2.11.0

Game info

Minecraft Version: 1.20.1 Fabric Loader Version: 0.14.21

Message autogenerated using MixinConflictHelper

repletsin5 commented 1 year ago

the only way i could fix is this by adding the ability to disable the mixin or decrase the priority ill look at this tomorrow.

repletsin5 commented 1 year ago

hello ive been trying to fix this. It seems the way i thought i could fix it isnt working so i may have to change the priority of the mixin, but that wont be obvious to the player. If they try and change the value in the config and it will not work they may think it is a bug, but it will be intended.(this wont just apply to the mod thats conflicting, but any mod that changes the same functions)

repletsin5 commented 1 year ago

im going to keep this open as i may find another way to fix it in the future. For now it will not be fixed

Xing-C commented 1 year ago

im going to keep this open as i may find another way to fix it in the future. For now it will not be fixed

But yes, prioritization is a solution . Now that I have to try to use it, I'm not sure if it's useful for the intended job, but it works.

17

repletsin5 commented 1 year ago

yes this is the fix i had in mind about. just those above are my concerns on why i havent added it yet, i might just remove the feature entirely if its causing a lot of incompatibility issues

Xing-C commented 1 year ago

yes this is the fix i had in mind about. just those above are my concerns on why i havent added it yet, i might just remove the feature entirely if its causing a lot of incompatibility issues

if you're unsure, consider adding a feature toggle and explaining it. I'm not quite certain about the specific purpose of this feature yet, so if it's not very important, you can try keeping it turned off by default.

repletsin5 commented 1 year ago

well from how ive implemented it just has a default value(vanilla), so ill add a full toggle. im an idiot and i dont know why i didnt do that in the first place lol.

Xing-C commented 1 year ago

well from how ive implemented it just has a default value(vanilla), so ill add a full toggle. im an idiot and i dont know why i didnt do that in the first place lol.

Ah this. Ah. Probably for the best.

repletsin5 commented 1 year ago

This has now been resolved by being disabled by default(will still cause compat issues when enabled but just keep it disabled if u know a mod is changing the anvil). Ive only finished the fabric 1.20 versions will do forge shortly.