search

replicahq / doppelganger

A Python package of tools to support population synthesizers
Apache License 2.0
165 stars 32 forks source link

Fix test in Population reading from file & add tests #3

Closed katbusch closed 7 years ago

katbusch commented 7 years ago

It also occurs to me we should be more consistent with ordering and naming of parameters

This change is Reviewable

kaelgreco commented 7 years ago
:lgtm:

Just missing an updated docstring for from_csvs.

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

doppelganger/populationgen.py, line 17 at r1 (raw file):


        Args:
            infile (unicode): path to csv

missed comments for new args

Comments from Reviewable

katbusch commented 7 years ago

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

doppelganger/populationgen.py, line 17 at r1 (raw file):

Previously, kaelgreco wrote…
missed comments for new args

Done.

Comments from Reviewable