Closed katbusch closed 7 years ago
The actual code looks and runs well. However, in order for this to be a unique_id, we should use the full tract id, including its state and county components. I.e.
STATEFP COUNTYFP TRACTCE PUMA5CE
01 001 020100 02100
01 001 020200 02100
01 001 020300 02100
01 001 020400 02100
01 001 020500 02100
01 001 020600 02100
01 001 020700 02100
01 001 020801 02100
01 001 020802 02100
Ideally we'd have tract_ids that look more like: "01001020802" than "20802", which is what I'm ending up with right now after generating synth households.
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
I also realize, this may very well be outside of the purview of this push
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Ah I got it. Okay, I agree that is outside the purview of this. We should add state & county throughout our code and then we can tie it into the unique ID. I will file a separate issue for that
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Made #36
Comments from Reviewable
This fixes #27, not in the requested way but in a cheap way that we can change later if we want. I also moved a few strings into the inputs file as constants to make the code easier to write/maintain
This change is