Closed katbusch closed 7 years ago
Yes, this worked!
small nit if relevant below
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.
doppelganger/populationgen.py, line 47 at r1 (raw file):
@staticmethod def _extract_households_evidence(allocated_rows, fields, segmenter, _):
super tiny nit: symmetry in naming, e.g. _extract_person_evidence
and _extract_household_evidence
(vs. plural). or is that a meaningful distinction?
Comments from Reviewable
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.
doppelganger/populationgen.py, line 47 at r1 (raw file):
super tiny nit: symmetry in naming, e.g. `_extract_person_evidence` and `_extract_household_evidence` (vs. plural). or is that a meaningful distinction?
Done.
Comments from Reviewable
@kaelgreco can you run this on your join in your notebook and make sure the output makes sense?
This change is