replicahq / doppelganger

A Python package of tools to support population synthesizers
Apache License 2.0
165 stars 32 forks source link

Separate person & household evidence generation #5

Closed katbusch closed 7 years ago

katbusch commented 7 years ago

@kaelgreco can you run this on your join in your notebook and make sure the output makes sense?


This change is Reviewable

kaelgreco commented 7 years ago
:lgtm:

Yes, this worked!

small nit if relevant below


Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


doppelganger/populationgen.py, line 47 at r1 (raw file):


    @staticmethod
    def _extract_households_evidence(allocated_rows, fields, segmenter, _):

super tiny nit: symmetry in naming, e.g. _extract_person_evidence and _extract_household_evidence (vs. plural). or is that a meaningful distinction?


Comments from Reviewable

katbusch commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


doppelganger/populationgen.py, line 47 at r1 (raw file):

Previously, kaelgreco wrote…
super tiny nit: symmetry in naming, e.g. `_extract_person_evidence` and `_extract_household_evidence` (vs. plural). or is that a meaningful distinction?

Done.


Comments from Reviewable