Install pomegranate from wheel and update CircleCI setup

replicahq / doppelganger

A Python package of tools to support population synthesizers

Apache License 2.0

165 stars 32 forks source link

Install pomegranate from wheel and update CircleCI setup #50

Closed bnaul closed 6 years ago

bnaul commented 6 years ago

This combines a couple of things:

Bump pomegranate to 0.8.1 (uses the new wheels that were just uploaded which should avoid the annoying installation problems)
Move requirements into requirements.txt
Update to the new CircleCI 2.0 config (this could be separated/removed, I just figured I might as well change it while I was in there; the tests run faster now since 2.7 and 3.6 happen in parallel)

This change is

katbusch commented 6 years ago

:fireworks:

Sweet!

Review status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions.

requirements.txt, line 4 at r2 (raw file):

numpy>=1.11.0
pandas>=0.19.0
pomegranate==0.8.1

Do we still need to pin the version? I guess future ones won't have wheels

.circleci/config.yml, line 1 at r2 (raw file):

version: 2

Yay!

.circleci/config.yml, line 36 at r2 (raw file):

      - run:
          name: Test
          command: |

Can you add back python --version and flake8 --version? They're useful for debugging differences between local & circle

Comments from Reviewable

alexeisw commented 6 years ago

Thats great. As we created https://github.com/sidewalklabs/doppelganger-internal for internal work (including Toronto), does this need to be replicated there too? :-/

Review status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

bnaul commented 6 years ago

I didn't know that fork existed but it's an easy change to make there too.

Review status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions.

requirements.txt, line 4 at r2 (raw file):

Previously, katbusch (Kat Busch) wrote…

Do we still need to pin the version? I guess future ones won't have wheels

I set up the wheels to build automatically when he does a release so it should be fine; changing to >=.

Comments from Reviewable

bnaul commented 6 years ago

Reviewed 4 of 6 files at r1, 1 of 1 files at r2, 2 of 2 files at r3. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

bnaul commented 6 years ago

This should be good to go :lgtmyself:

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

katbusch commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

.circleci/config.yml, line 36 at r2 (raw file):

Previously, katbusch (Kat Busch) wrote…

Can you add back `python --version` and `flake8 --version`? They're useful for debugging differences between local & circle

ping?

Comments from Reviewable

katbusch commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable