search

replicahq / doppelganger

A Python package of tools to support population synthesizers
Apache License 2.0
165 stars 32 forks source link

Update comment and put init on top #51

Closed DOsinga closed 6 years ago

DOsinga commented 6 years ago

This change is Reviewable

katbusch commented 6 years ago
:lgtm:

Thanks! Not sure what's going on with the tests but after #50 is merged they'll at least be easier to parse :)

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

DOsinga commented 6 years ago

It seems to die on flake unrelated to this change:

./doppelganger/inputs.py:107:1: W293 blank line contains whitespace ./doppelganger/inputs.py:175:1: W293 blank line contains whitespace ./doppelganger/inputs.py:183:1: W293 blank line contains whitespace ./doppelganger/inputs.py:271:64: W292 no newline at end of file ./doppelganger/listbalancer.py:134:5: E741 ambiguous variable name 'I' ./doppelganger/listbalancer.py:159:40: E741 ambiguous variable name 'I' ./doppelganger/scripts/download_allocate_generate.py:213:5: E722 do not use bare except'

deactivate && pyenv shell 3.6.1 && bash -c "$TESTCMD" returned exit code 1

Happy to fix those, except for the last one, since I am not sure which exception we expect in that situation.

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

katbusch commented 6 years ago

I would try rebasing on master since the circle configs have changed today

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

DOsinga commented 6 years ago

Great, works now!

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable