search

replicahq / doppelganger

A Python package of tools to support population synthesizers
Apache License 2.0
165 stars 32 forks source link

addressed asserEquals deprected warning, changed to assertEqual #64

Closed anthonylouisburns closed 6 years ago

anthonylouisburns commented 6 years ago

This change is Reviewable

katbusch commented 6 years ago

Thanks for the clean up @anthonylouisburns!

katbusch commented 6 years ago

Looks like you have a minor lint issue from the change. You can run flake8 to lint locally for testing.

katbusch commented 6 years ago

Looks like there's an issue with coveralls. No changes are needed on your end for that respect--I'll fix it on master.

Can you revert the changes to doppelganger_example_simple.ipynb though?

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

anthonylouisburns commented 6 years ago

@katbusch addressed the flake8 issue - not sure why I am getting a failure

Submitting coverage to coveralls.io... Coverage submitted! Couldn't find a repository matching this job. 'url' Exited with code 2

katbusch commented 6 years ago

It's a problem with our coveralls config--nothing you did. I'll fix it and merge this when it's fixed

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable