search

replicate / cog

Containers for machine learning
https://cog.run
Apache License 2.0
8.08k stars 561 forks source link

Hard code version number in Cog #556

Open bfirsh opened 2 years ago

bfirsh commented 2 years ago

A brief discussion: https://discordapp.com/channels/775512803439280149/958761235720069220

evilstreak — Today at 17:14 A thought: should we reject models built with the Cog version of dev? We're going to run into problems providing backwards compatibility for those, as we don't know what version of inputs/outputs they'll be expecting bfirsh — Today at 17:18 yes, probably. and we should probably hard code versions in cog. this is a conversation that @zeke and I have had back and forth. can't remember if anything is written down about this. evilstreak — Today at 17:19 Update the value of globals.Version in code whenever we want to change the version? That'd make the local install thing better We could even make it install as 0.1.4-dev so we can distinguish between release versions and possibly modified versions (obv fakeable for anyone motivated to do so, but it might help us debug if we're seeing weird issues with some models) zeke — Today at 17:20 dev suffix sounds like a good idea

bfirsh commented 2 years ago

Reopening this because if you fork and do a build, then you don't have any tags locally and the version doesn't get set. https://canary.discord.com/channels/775512803439280149/994294965574303826/1002257687356125295

At Replicate, we rely on the version number to determine what API the Cog container speaks, so perhaps we need a more reliable way of determining version number.

(thanks @palp for uncovering!)