Install instructions don't work on fish shell

replicate / cog

Containers for machine learning

https://cog.run

Apache License 2.0

7.88k stars 549 forks source link

Install instructions don't work on fish shell #818

Closed zeke closed 1 year ago

zeke commented 1 year ago

fish doesn't support backticks, so this doesn't work:

sudo curl -o /usr/local/bin/cog -L https://github.com/replicate/cog/releases/latest/download/cog_`uname -s`_`uname -m`

One way to work around this would be to echo the contents of the script and pipe it into bash.

Prior art: https://github.com/dependabot/cli/tree/afb2e1ba322344c90106357d058c15193404fd1a#installation

cc @mattt

mattt commented 1 year ago

Thanks for writing this up, @zeke.

One way to improve the installation process would be to distribute cog via Homebrew. I opened an issue tracking that with https://github.com/replicate/cog/issues/822, which includes a working formula.

The formula requires a few changes to Makefile, which I submitted in #823. Even without a formula, accepting that PR would allow you to simplify the README instructions to make install.