replicate / cog

Containers for machine learning
https://cog.run
Apache License 2.0
8.08k stars 562 forks source link

Keeping the homebrew formula up to date #850

Closed zeke closed 1 year ago

zeke commented 1 year ago

brew install cog is a thing now! See https://github.com/replicate/cog/pull/849 and https://github.com/Homebrew/homebrew-core/pull/117929

It looks like it's pinned at 0,5.1. How should we go about keeping that up to date as we release new versions of Cog? My guess at a couple options:

zeke commented 1 year ago

cc @mattt

mattt commented 1 year ago

@zeke Honestly, I'm still a bit confused about what the expectations for contributors are after a formula is accepted.

Looking at open PRs, I'm noticing that a small set of users are contributing updates and they all seem to use brew bump-formula-pr. But looking at repos associated with core formulas, I'm getting mixed signals:

Based on this, I propose that we do the following:

Sound good?

zeke commented 1 year ago

Sounds like a plan 👍🏼

mattt commented 1 year ago

@zeke @nickstenning @evilstreak I saw that we just released 0.6.0, which includes a fix for an issue with CUDA base images. Is everyone on board with the plan to see if/when homebrew-core updates the cog formula? Or are the changes in this version important enough to merit a manual override?

nickstenning commented 1 year ago

Unfortunately in this case cog<0.6.0 is likely to be completely broken for everyone thanks to those Interesting Decisions:tm: made at nvidia.

That said, I doubt that hordes of people are already relying on homebrew for cog, so I'm ok with us waiting if we want.

mattt commented 1 year ago

@zeke @nickstenning The cog formula was bumped to 0.6.1 two days ago by a homebrew-core maintainer, which was two days after the version was released. So it looks like there's a reasonable expectation of eventual consistency, on the order of a few days. 😃

zeke commented 1 year ago

The cog formula was bumped to 0.6.1 two days ago by a homebrew-core maintainer,

Nice! Let's call this done then, and revisit if we ever need to.