search

replicate / keepsake

Version control for machine learning
https://keepsake.ai
Apache License 2.0
1.65k stars 72 forks source link

PyTorch Lightning tests shouldn't hit network #551

Open bfirsh opened 3 years ago

bfirsh commented 3 years ago

Currently the PyTorch Lightning tests download mnist and train a real model. We shouldn't do that to just test that the callback works -- they should run a fake training process of some kind.

gabrielmbmb commented 3 years ago

Maybe, some kind of fake data could be generated with NumPy or PyTorch instead of using a "real" dataset?

bfirsh commented 3 years ago

Yeah this doesn't need to do anything real.

bfirsh commented 3 years ago

These files are pretty small. Could just include them in the repo. Ideally we'd have a test that didn't actually do anything on real data though. https://github.com/golbin/TensorFlow-MNIST/tree/master/mnist/data

gabrielmbmb commented 3 years ago

A pytext fixture with dummy generated train data could be nice, as it could be used in future test cases easily.