search

replicate / replicate-python

Python client for Replicate
https://replicate.com
Apache License 2.0
696 stars 194 forks source link

asynchronously close of response #309

Closed alex-does-stuff closed 2 weeks ago

alex-does-stuff commented 1 month ago

The response is closed synchronously in the async path, unnecessarily blocking. The PR closes the response asynchronously instead

mattt commented 4 weeks ago

@alex-does-stuff Ah, nice catch! Thanks for opening this PR.

CI is failing because some integration tests require an auth token, but that isn't set in forks. That's a relatively new change, so I'll work on a fix for that.

mattt commented 2 weeks ago

@alex-does-stuff Thanks again for your help. And thanks for your patience in me getting CI sorted. Merging this now 😄