search

replicatedhq / kURL

Production-grade, airgapped Kubernetes installer combining upstream k8s with overlays and popular components
https://kurl.sh
Apache License 2.0
756 stars 78 forks source link

When a proxy fails, the password should not be dumped to the screen #516

Open laverya opened 4 years ago

laverya commented 4 years ago

https://github.com/replicatedhq/kURL/blob/a18c2e2a488c5f28dc6504b84f38bf73f0c605a8/scripts/common/proxy.sh#L68

Ideally, HTTPS_PROXY=https://USERNAME:PASSWORD@10.0.0.1:8080/ would be redacted to not show the password.

camilamacedo86 commented 1 year ago

Hi @laverya,

This one is very old. Things that were not get done in the latest 2 yrs probably will not be done soon :-) So, would still that a need? Should we kept this one open or can we close this RFE?