replicatedhq / kots

KOTS provides the framework, tools and integrations that enable the delivery and management of 3rd-party Kubernetes applications, a.k.a. Kubernetes Off-The-Shelf (KOTS) Software.
https://kots.io
Apache License 2.0
897 stars 88 forks source link

HelmChart spec, exclude field should be a BoolString, not a string #443

Closed marccampbell closed 1 year ago

marccampbell commented 4 years ago

It would allow more flexibility in templating this field:

https://github.com/replicatedhq/kots/blob/master/kotskinds/apis/kots/v1beta1/helmchart_types.go#L240

cbodonnell commented 1 year ago

This has been completed. The field is now a multitype.BoolOrString: https://github.com/replicatedhq/kots/blob/v1.90.0/kotskinds/apis/kots/v1beta1/helmchart_types.go#L356