fix(proxy): use fqdn for kotsadm-rqlite and kotsadm-minio addresses

replicatedhq / kots

KOTS provides the framework, tools and integrations that enable the delivery and management of 3rd-party Kubernetes applications, a.k.a. Kubernetes Off-The-Shelf (KOTS) Software.

https://kots.io

Apache License 2.0

902 stars 90 forks source link

fix(proxy): use fqdn for kotsadm-rqlite and kotsadm-minio addresses #4874

Closed emosbaugh closed 2 months ago

emosbaugh commented 2 months ago

What this PR does / why we need it:

When setting NO_PROXY env var to include .cluster.local this will not work with the shorthand dns.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

KOTS will now use the fully qualified .svc.cluster.local address when making requests to kotsadm-rqlite and kotsadm-minio services for simplified HTTP proxy configuration using `NO_PROXY=.cluster.local`.

Does this PR require documentation?

github-actions[bot] commented 2 months ago

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/KOTS-2024.9.9-d7f6fb-nightly-4874-merge-d7f6fbe-kotsadm-2024.9.9-d7f6fb-nightly-k8s-docker-2024-09-09T22:28:44Z