search

replicatedhq / kots

KOTS provides the framework, tools and integrations that enable the delivery and management of 3rd-party Kubernetes applications, a.k.a. Kubernetes Off-The-Shelf (KOTS) Software.
https://kots.io
Apache License 2.0
902 stars 90 forks source link

fix(upgrade-service): allow no preflights and no config #4942

Closed JGAntunes closed 1 month ago

JGAntunes commented 1 month ago

What this PR does / why we need it:

This PR fixes the upgrade flow for when an upgrade doesn't have config or preflight checks (the shortcut story has a video which illustrates the whole flow).

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/113259/new-upgrade-workflow-doesn-t-work-if-there-is-no-config https://app.shortcut.com/replicated/story/113787/upgrade-workflow-doesn-t-work-if-you-don-t-have-preflights

Does this PR require a test?

Yes, I'll be looking into adding a playwright test to the EC repo.

Does this PR require a release note?

Fix for the upgrade flow in embedded cluster when there's no config and/or preflight checks available.

Does this PR require documentation?

NONE

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

laverya commented 1 month ago

lint-web has a few failures - any reason those can't be fixed?

JGAntunes commented 1 month ago

Ok, after fighting a lot with jest, react router and its related friends I think this is ready for review. Could I get a 👀 again @sgalsaleh and @miaawong 🙏 There's a bit of noise in the tests because some of the components we're testing end up logging a lot but the tests are 🟢 if y'all want I can eventually remove the console.* calls we have spread out, or potentially silence them in some way in jest.