replicatedhq / kotsadm

Kotsadm has been merged into the KOTS repo
https://github.com/replicatedhq/kots
Apache License 2.0
248 stars 9 forks source link

Development Environment: Does not match production kots installs #1460

Open dexhorthy opened 4 years ago

dexhorthy commented 4 years ago

I noticed that the development environment for kotsadm deploys the github.com/schemahero/schemahero operator and CRDs, and that skaffold creates and terminates the namespace on every skaffold dev invocation/exit. This causes two issues:

  1. cannot ctrl+c skaffold dev and then run it again, need to wait some time for schemahero namespace to terminate, or else you get errors like
Error from server (Forbidden): error when creating "migrations/kustomize/base/schemahero.yaml": secrets "schemahero-webhook-server-secret" is forbidden: unable to create new content in namespace schemahero-system because it is being terminated
  1. This does not match what the kots CLI does in production, which is to run a single Job that invokes the schemahero CLI (using schemahero Operatorless Mode)

Would it be reasonable to convert the local dev environment to closer match what happens in production, using a Job to do applies?

dexhorthy commented 4 years ago

cc @marccampbell please let me know what you think. The operator makes contributor experience a little wonky, and also creates a difference between dev and prod which I think is fairly significant -- is there a reason things are set up this way in the skaffold env?