Upgrade to helm v2.15.0

replicatedhq / ship

A better way to deploy Kubernetes Helm charts

https://www.replicated.com/ship

Apache License 2.0

636 stars 70 forks source link

Upgrade to helm v2.15.0 #1079

Closed chenrui333 closed 5 years ago

chenrui333 commented 5 years ago

What I Did

Upgrade dependencies:

helm v2.15.0

How I Did it

For helm upgrade

go get helm@v2.15.0
go mod tidy

How to verify it

Description for the Changelog

Picture of a Ship (not required but encouraged)

Flying ship!

laverya commented 5 years ago

I think this needs a run of go mod vendor

chenrui333 commented 5 years ago

Thanks, let's try it!

chenrui333 commented 5 years ago

I am going to just to have this PR focus on the helm upgrade and have another PR to do the k8s api upgrade (maybe that requires some code changes).

chenrui333 commented 5 years ago

The failures all point to:

# k8s.io/helm/pkg/chartutil
vendor/k8s.io/helm/pkg/chartutil/values.go:136:22: too many arguments in call to yaml.Unmarshal
    have ([]byte, *Values, func(*json.Decoder) *json.Decoder)
    want ([]byte, interface {})

chenrui333 commented 5 years ago

Not quite sure why a helm-3 PR got slipped into helm 2.15.0.

PR ref: https://github.com/helm/helm/pull/6032

laverya commented 5 years ago

That's really weird - the function signature for sigs.k8s.io/yaml's Unmarshal hasn't changed in years: https://github.com/kubernetes-sigs/yaml/blame/master/yaml.go#L35

chenrui333 commented 5 years ago

The commit, https://github.com/helm/helm/commit/f94bac0643ad5d39c740c57c6c8ea6a4569a1db0#diff-c508e0fda01b39eddfe1d6a4449fe685R109-R112 did make some changes (kind of violating the signature).