replicatedhq / troubleshoot

Preflight Checks and Support Bundles Framework for Kubernetes Applications
https://troubleshoot.sh
Apache License 2.0
543 stars 92 forks source link

fix: flaky goldpinger e2e test #1499

Closed banjoh closed 6 months ago

banjoh commented 6 months ago

Description, Motivation and Context

Installing the chart at times takes too long. We'll increase the wait time to 2m for the application to be healthy

Here is a failing test result from https://github.com/replicatedhq/troubleshoot/actions/runs/8155128183/job/22290082789 action run

=== RUN   Test_GoldpingerCollector/Goldpinger_collector_and_analyser/collect_and_analyse_goldpinger_pings
    goldpinger_collector_e2e_test.go:85: 
            Error Trace:    /home/runner/work/troubleshoot/troubleshoot/test/e2e/support-bundle/goldpinger_collector_e2e_test.go:85
                                        /home/runner/go/pkg/mod/sigs.k8s.io/e2e-framework@v0.3.0/pkg/env/env.go:428
                                        /home/runner/go/pkg/mod/sigs.k8s.io/e2e-framework@v0.3.0/pkg/env/env.go:466
            Error:          Not equal: 
                            expected: 1
                            actual  : 0
            Test:           Test_GoldpingerCollector/Goldpinger_collector_and_analyser/collect_and_analyse_goldpinger_pings
--- FAIL: Test_GoldpingerCollector (95.87s)

Checklist

Does this PR introduce a breaking change?