fix: Use correct cron job kind when discovering API versions

banjoh commented 4 months ago

Description, Motivation and Context

Use correct cron job kind when discovering API versions

Fixes: https://github.com/replicatedhq/troubleshoot/issues/1553

Checklist

[ ] New and existing tests pass locally with introduced changes.
[x] Tests for the changes have been added (for bug fixes / features)
[x] The commit message(s) are informative and highlight any breaking changes
[ ] Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

[ ] Yes
[x] No

diamonwiggins commented 4 months ago

I've approved, but I guess I do have a question. The issue this is referencing says that the issue was batch/v1beta1/cronjobs vs batch/v1/cronjobs. Does changing this from CronJobs to CronJob actually fix this?

banjoh commented 4 months ago

I've approved, but I guess I do have a question. The issue this is referencing says that the issue was batch/v1beta1/cronjobs vs batch/v1/cronjobs. Does changing this from CronJobs to CronJob actually fix this?

It does. Below is a snippet of the API description object fetched from the API server during discovery. The "kind": "CronJob") field is used in discovery.HasResource() to select the resource. That condition always failed due to the typo. The API call we see in the logs contains a concatenation of values from "groupVersion" and "name" fields. Hope that makes sense.

  {
    "groupVersion": "batch/v1",
    "resources": [
      {
        "name": "cronjobs",
        "singularName": "cronjob",
        "namespaced": true,
        "kind": "CronJob",
        "verbs": [
          "create",
          "delete",
          "deletecollection",
          "get",
          "list",
          "patch",
          "update",
          "watch"
        ],
        "shortNames": [
          "cj"
        ],
        "categories": [
          "all"
        ]
      },

replicatedhq / troubleshoot