replikation / poreCov

SARS-CoV-2 workflow for nanopore sequence data
https://case-group.github.io/
GNU General Public License v3.0
39 stars 16 forks source link

Nextclade docker update #157

Closed replikation closed 2 years ago

replikation commented 2 years ago
replikation commented 2 years ago
hoelzer commented 2 years ago

@replikation looks basically good and runs also in our restricted environment w/ Singularity. But I noticed some difference regarding deletions in Delta sequences. Basically, w/ v0.10.3 we always see the deletion

S:F157-, S:R158-

but with the current nextclade_docker_update branch we always see

S:E156-, S:F157-

So shifted by one position. The other SNPs seem fine. Another Delta-characteristic deletion at position

ORF8:D119-, ORF8:F120-

ist not touched... so stays same between the two versions.

Any idea where this difference could come from? 0_0

v0.10.3 image

This branch image

hoelzer commented 2 years ago

One second... you extract the information about insertions and deletions from the Nextclade output, right? Then there might be a difference between the quite old and new nextclade version and that causes the difference. Actually, the new positions might be even more accurate

hoelzer commented 2 years ago

yep, the consensus sequences are exactly the same (same md5sum) but Nextclade versions annotate this specific deletion position differently. Hach, Friday edge case discovered :leichtes_lächeln: but that's fine I would say. Likely even more accurate then the old Nextclade information

replikation commented 2 years ago

ah yes nexclade is new they adjusted some things. the nextclade version and database version is now also noted on the final report to avoid "differences" between databases. Thank you ill do some testing merge and prep a release