replikation / poreCov

SARS-CoV-2 workflow for nanopore sequence data
https://case-group.github.io/
GNU General Public License v3.0
39 stars 16 forks source link

Add Scorpio + constellations column and versions #176

Closed RaverJay closed 2 years ago

RaverJay commented 2 years ago

Bonus:

Needs testing

hoelzer commented 2 years ago

great thx @RaverJay !

Just did a test run (that has no Omicron included). But no scorpio information added to the report? I suggest to simply add another row after the pangolin version

Direct assignments via lineage-specific constellation files are performed via scorpio version xxx using constellation versions yyyy 

image

hoelzer commented 2 years ago

I will also da test w/ public omicron raw data now

RaverJay commented 2 years ago

Yeah the logic was flipped for testing, fixed now - please pull the latest commit

Thanks for testing!

RaverJay commented 2 years ago

image

RaverJay commented 2 years ago

Maybe we should add a warning if the Pangolin / Nextclade version is very old, because I had this is my first test, obviously the PangoLEARN from July is pretty much useless now

hoelzer commented 2 years ago

Great, looks good now also here! And such a warning would be great if you can easily add it. Bc/ yeah, if someone fails to run the --update command the lineage assingments can be really odd

RaverJay commented 2 years ago

How about this: image

And keep the PangoLEARN version also in this top part. Could do the same for NextClade?

hoelzer commented 2 years ago

@RaverJay ! great, having this in the report is even better than in terminal. Yeah, would be also nice for Nextclade then if you can easily add that

hoelzer commented 2 years ago

So looks good I'd say, also just did another regular run again with the current PR version:

image

RaverJay commented 2 years ago

image Nextclade data version is in

hoelzer commented 2 years ago

@RaverJay can this be merged from your side? I also just run a test, looks all good!

RaverJay commented 2 years ago

Well it works for me, but I never trust changes until Chris has run some cloud tests :D

hoelzer commented 2 years ago

;) I agreed w/ him that we merge smaller changes and do prerelases, he will then later also test and then we do a major release