Closed hoelzer closed 2 years ago
yep this might need some adjustments on final report @RaverJay but will simplify the overview
Example output of the new version:
Great overview of the changes: https://cov-lineages.org/resources/pangolin/pipeline.html
Looks great, this will simplify things a lot
And a nice thread summarizing the main changes again
@replikation when will the container be ready? :)
@replikation when will the container be ready? :)
I guess at the moment when the new pango v4.0 is on bioconda :D
No we are building from git directly to avoid delays @hoelzer. but the auto builds have a few checks to not cause an issue on poreCov (e.g. are the columns present - and it currently tags via pangolin and pangolearn version). this might be a bit annoying now to switch the whole thing in combination with porecov. (e.g. --update might break now older poreCov versions). SO i might need to fork and create a "pangolin4" container going forward or so. need to check first
Edit: yes the column headers are changed. need to create a new pangolin fork to avoid issues
@RaverJay i guess the html report creates an error if it cant get the correct versions?
uhh, you're right @replikation I thought we build from bioconda. Ah yes, and now basically older versions of poreCov can only use pangolin containers until a certain release. Okay, that's a bit annoying -.-
@RaverJay i guess the html report creates an error if it cant get the correct versions?
Yes, it will fail when the columns it needs are not there
There will be an update that changes the way pangoLEARN, etc... are used and aims to harmonize all that stuff into a single
pangolin-data
dependency:https://github.com/cov-lineages/pangolin/issues/386#issuecomment-1082088001
We should be aware of that and might have to change some code (version numbers, report, ...) when this update happens.