replikation / poreCov

SARS-CoV-2 workflow for nanopore sequence data
https://case-group.github.io/
GNU General Public License v3.0
39 stars 17 forks source link

Pangolin4 update #224

Closed RaverJay closed 2 years ago

RaverJay commented 2 years ago

closes #220

Cannot test for now, need the 4.0 container :)

Edit: Added nextclade private mutation information to the datatable ( closes https://github.com/replikation/poreCov/issues/226 )

hoelzer commented 2 years ago

wow, this was even faster then the new version can be on bioconda :D

replikation commented 2 years ago

so what versions do we need to track now? pangolin version and pangolindata?

additionally which columns do we need to track? @RaverJay

replikation commented 2 years ago

@RaverJay iam currently tracking the following columns for the autobuild to ensure that they are present for your report, this would be fine?

"taxon," || exit 1; }
 ",lineage," || exit 1; }
",conflict," || exit 1; }
",pangolin_version," || exit 1; }
 ",scorpio_version," || exit 1; }
 ",constellation_version," || exit 1; }
 ",qc_status," || exit 1; }
 ",qc_notes," || exit 1; }

if yes ill start the build and post the new docker name here. ill need to add a few other commits on top of it too (so that e.g. --update works fine)

replikation commented 2 years ago

nanozoo/pangolin-v4:4.0--1.2.133

RaverJay commented 2 years ago

Pulling and testing now

The (new) report uses these columns:

taxon,lineage,conflict,scorpio_call,scorpio_conflict
version,pangolin_version,scorpio_version,constellation_version
RaverJay commented 2 years ago

Works now

image

image

hoelzer commented 2 years ago

awesome

hoelzer commented 2 years ago

"variants tableof" is missing a whitespace : )

RaverJay commented 2 years ago

"variants tableof" is missing a whitespace : )

fixed :D

RaverJay commented 2 years ago

Added nextclade private mutation information to the datatable ( closes #226 ) Somewhat unrelated, but a minor change

replikation commented 2 years ago

@RaverJay added the columns to the docker autobuild to check if they are present

replikation commented 2 years ago