add backend and lib versions to database metadata

replikativ / datahike

A fast, immutable, distributed & compositional Datalog engine for everyone.

https://datahike.io

Eclipse Public License 1.0

1.62k stars 95 forks source link

add backend and lib versions to database metadata #535

Closed yflim closed 2 years ago

yflim commented 2 years ago

SUMMARY

Add backend and lib versions to database metadata

Feature

[ ] Implements an existing feature request. Make sure the feature request has been accepted for implementation before opening a PR.
[ ] Related issues linked using fixes #number
[ ] Integration tests added
[ ] Documentation added
[ ] Architecture Decision Record added
[ ] Formatting checked
[ ] CHANGELOG.md updated

jsmassa commented 2 years ago

As I understand it, we don't want jdbc artefacts in the main library. Can we close this PR then @kordano?

jsmassa commented 2 years ago

So, yes, backend specific information should be treated by the respective backend library, so datahike doesn't have to pull potentially huge additional libraries.

whilo commented 2 years ago

I think in case you want to have this metadata in there but not pull dependencies there should be a metadata protocol for the Datahike backends and you just invoke this in meta-data. I do not know the background of this PR though.