search

replikativ / datahike

A fast, immutable, distributed & compositional Datalog engine for everyone.
https://datahike.io
Eclipse Public License 1.0
1.62k stars 95 forks source link

fix: commit classes for git deps #644

Closed groundedsage closed 10 months ago

whilo commented 11 months ago

Nice, thanks! Which Java version did you compile the class files with?

TimoKramer commented 11 months ago

Why would you want that class files in the repo? Is there a Problem somewhere that justifies that?

whilo commented 11 months ago

Yes, the problem is that you cannot directly use deps with git anymore, because you first need to compile the dependency locally and then point to the jar for each commit and branch. This means any non-released datahike version cannot be easily used and tested by downstream projects. Electric also commits class files like this because they barely change and are small (our Java binding is very stable).

TimoKramer commented 11 months ago

I can not find a class file in the electric repo, where can I find it? Why is this not sufficient? Also, as you pointed out, with which version are the class files compiled?

whilo commented 11 months ago

@groundedsage Did you try to use prep-lib?

TimoKramer commented 10 months ago

closing for now

groundedsage commented 10 months ago

@TimoKramer classes are in this directory and mentioned in build.md

I just tried pre-lib and this did not work. On the surface this does appear to be the correct way to handle this though. I will submit an issue for this specifically.