replikativ / datahike

A fast, immutable, distributed & compositional Datalog engine for everyone.
https://datahike.io
Eclipse Public License 1.0
1.62k stars 95 forks source link

bugfix: use store identity in config check #655

Closed alekcz closed 9 months ago

alekcz commented 9 months ago

SUMMARY

The store-identity is implemented as part of the backend protocol but is not used in assessing if configurations are equivalent. As a result two stores are functionally equivalent are not be deemed so unless they are literally equivalent. This fix uses the store-identity to check equivalence for configurations and connections.

e.g. on JDBC these two stores are equivalent but not be deemed so. They appear different as because in one case the DB and datahike are on the same network and the in the other they are not.

(def pg-cfg  {:dbtype  "postgresql" :jdbcUrl "postgresql://user:password@localhost/konserve"})
(def pg-cfg  {:dbtype  "postgresql" :jdbcUrl "postgresql://user:password@myremoteaddress.com/konserve"})
Bugfix
alekcz commented 9 months ago

@whilo this should address #654