search

replikativ / hasch

Cross-platform (JVM and JS atm.) edn data structure hashing for Clojure.
Eclipse Public License 1.0
111 stars 13 forks source link

Exclude JS/HTML from jar file #22

Closed MrEbbinghaus closed 3 years ago

MrEbbinghaus commented 3 years ago

This excludes the directories "public" and "private" from the built jar. They only contain JS and tests, so they aren't necessary.

MrEbbinghaus commented 3 years ago

This leads to things like these:

image

TimoKramer commented 3 years ago

Hi @MrEbbinghaus. Thanks a lot for this PR and sorry for the late reply. I am happy to merge this. As you can see on the development branch we are currently switching the repositories over to deps.edn. That means it would be more valuable if you have a suggestion on how to avoid packaging these files with depstar. Do you want to tackle that as well?

MrEbbinghaus commented 3 years ago

Hi @TimoKramer. I think the problem doesn't exist with deps. I looked into it a bit more. leiningen seems to include a /resources directory in the jar by default, when you don't specify otherwise (e.g. :resource-paths []). depstar does not.

(I see there is an existing pull request https://github.com/replikativ/superv.async/pull/11 . That should fix the other problem in the screenshot above.)

TimoKramer commented 3 years ago

Thanks for the PR then and I checked with depstar and you are correct that resources are not in there.