replikativ / hitchhiker-tree

Functional, persistent, off-heap, high performance data structure
Eclipse Public License 1.0
44 stars 19 forks source link

Compare deref fix #24

Closed whilo closed 3 years ago

whilo commented 3 years ago

@ajoberstar This performs better than https://github.com/replikativ/hitchhiker-tree/pull/22, but thank you very much for tracking down the issue! And thanks to @mpenet for the suggestion!

whilo commented 3 years ago

@groundedSAGE This might require to stick to the old version with reader literal for cljs.

groundedsage commented 3 years ago

@groundedSAGE This might require to stick to the old version with reader literal for cljs.

This has been updated on my fork. We can incorporate those changes before the release.

whilo commented 3 years ago

Ok, yes. Then let's merge Timo's PR first. Then yours Wade (after rebasing) and then just incorporate that fix (it is a one line fix). @groundedSAGE Can you take charge of the rebase and incorporating the fix here?

mainej commented 3 years ago

@whilo this fix was merged into development, but hasn't made it to master. Is that merge forthcoming?

whilo commented 3 years ago

@mainej Yes, it is.