Closed piemadd closed 2 years ago
Can I see what it looks like on your repl?
Sure thing: https://blogbeta.piemadd.repl.co/solidity
On Fri, Nov 12, 2021, 16:57 ykdojo @.***> wrote:
Can I see what it looks like on your repl?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/replit/blog/pull/11#issuecomment-967713541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOJ3UHXHY7AJMXDRPHYMETULWLUJANCNFSM5H32BPQA .
Not a bug, soren/tyler just put two lines into the post
On Sat, Nov 13, 2021, 12:34 Sergei Chestakov @.***> wrote:
@.**** commented on this pull request.
Awesome, this looks great Piero! Have a couple suggestions.
Also: I noticed there's a bug on mobile that's causing some of the dividers to appear twice [image: Screen Shot 2021-11-13 at 10 30 51 AM] https://user-images.githubusercontent.com/24947334/141655278-ca697d7f-e5ac-41ae-ac07-c6659c3f5032.png
Not related to your changes but we should follow up with a fix
In views/post-page.ejs https://github.com/replit/blog/pull/11#discussion_r748751506:
@@ -93,6 +93,16 @@
<%- include('post', { post }); %>
+
Liking what you've read? You can
can we change the text here to: ⬇️ Suggested change
Liking what you've read? You can
Like what you read? You can
In static/style.css https://github.com/replit/blog/pull/11#discussion_r748751653:
@@ -567,6 +567,58 @@ white-space: pre-wrap;
margin-bottom: 20px;
}
+.twitter-cta {
display: flex;
align-items: center;
justify-content: center;
max-width: 90%;
+}
+
+.twitter-cta > div {
display: flex;
flex-direction: row;
align-content: center;
align-items: center;
color: var(--text-color);
margin: 0;
font-size: 1.5em;
can you make the text smaller here? it's a little big especially on mobile: [image: Screen Shot 2021-11-13 at 10 31 51 AM] https://user-images.githubusercontent.com/24947334/141655253-e30f9c57-61e5-4a3b-88de-a6ee4c8e1276.png
Ideally the text before the button doesn't wrap around like that on most major devices.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/replit/blog/pull/11#pullrequestreview-805392584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOJ3UD27NXVVADB2YLOC63UL2VS3ANCNFSM5H32BPQA .
ykdojo commented 2 years agoI didn't read the code carefully, so I'll defer to Sergei or someone else for that.
For the copy, let's change "Liking what you've read?" to "Like what you've read?"
Otherwise it looks good!
replbot commented 2 years agounbooping: approved
The twitter call to action brings people having reached the end of a blogpost right to our twitter to follow. This will be followed in the coming weeks/months with recommended articles.