Closed piemadd closed 3 years ago
Looks good! I don't think I'll be able to look at the code, so if you want someone to review it, you should ask @Zwork101
This PR is getting big. To make it easier for others to review you might want to breaking it up into smaller changes.
unbooping: approved
Yeah lmao, it's for the replit debugger, doesn't do anything, and iirc its only used on a single markdown file??
On Thu, Sep 23, 2021, 19:59 Mason Clayton @.***> wrote:
@.**** commented on this pull request.
In .breakpoints https://github.com/replit/blog/pull/6#discussion_r715249542:
@@ -4,9 +4,9 @@ {
can we just delete this file lmao
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/replit/blog/pull/6#pullrequestreview-762615795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOJ3UABWRLNECCJHREYF4TUDPEPZANCNFSM5EUWQ2AA .
Will take a look this weekend if I get a chance. Or Monday
On Fri, Sep 24, 2021, 9:12 PM Piero Maddaleni @.***> wrote:
@pieromqwerty https://github.com/pieromqwerty requested your review on:
6 https://github.com/replit/blog/pull/6 Categories, Theme Control, CSS
Bugfixes, Cache Gap Fix.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/replit/blog/pull/6#event-5359115225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPG2LETYJPJC5NH2NGBXQTUDVD3DANCNFSM5EUWQ2AA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
@masad-frost bro
Cool. One thing to note is that I originally had it handled by the server, but more than 10-20 people clicking about absolutely spammed the blog and it also took some time to resolve. Merging.
This update has added a few features, and fixed quite a few bugs:
Categories: Hidden behind
?beta=1
, categories, each post is categorized under a, well, category. If no category is assigned, it is automatically under 'other'. If product, infra, or projects is a tag, and eng is not a tag, the eng tag is automatically applied.Theme Control: The user's preferred theme is automatically applied, but a button in the bottom left lets them change this. Also behind beta wall
CSS Bug Fixes: Small fixes like making the arrow go left instead of the text go right when hovering over back to blog. Not behind beta tag.
Cache Gap Fix: If the blog is hit before the initial load of posts is finished, the returned page would be blank. To fix this, the server doesn't start until this is complete. This makes sure the experience for users isn't ruined unintentionally.