search

replit / blog

the code behind https://blog.replit.com/
https://blog.replit.com
18 stars 11 forks source link

Moved the theme control block out of the is/isn't beta section. #7

Closed piemadd closed 3 years ago

piemadd commented 3 years ago

This PR removes the requirement for ?beta=1 to have theme switching/dark theme.

replbot commented 3 years ago

Good work, this PRs short and easy to review! Promoting to bop.

ykdojo commented 3 years ago

I haven't tested it but it looks good. Feel free to merge it

replbot commented 3 years ago

unbooping: approved

piemadd commented 3 years ago

@ykdojo Please pull from master on the blog repl

ykdojo commented 3 years ago

@pieromqwerty you're not on util?

piemadd commented 3 years ago

@ykdojo I am but it errors out when i try pushing/pulling to/from git in the blog repl. Weirdly enough no problems on my account.

ykdojo commented 3 years ago

Strange. What's the error?

On Tue, Oct 5, 2021 at 2:49 PM Piero Maddaleni @.***> wrote:

@ykdojo https://github.com/ykdojo I am but it errors out when i try pushing/pulling to/from git in the blog repl. Weirdly enough no problems on my account.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/replit/blog/pull/7#issuecomment-934896109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2JQ2QV55GLLC66F5AYE3UFNXGXANCNFSM5FMVUKUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ykdojo commented 3 years ago

@pieromqwerty

piemadd commented 3 years ago

Theres no error, just fails to pull and makes git get out of sync. Caused lots of issues last time I tried to pull.

ykdojo commented 3 years ago

Did you try fetch and then merge?

piemadd commented 3 years ago

Not touching the console. Last time I did I brought down the blog for a minute. Not again, especially in prod.

piemadd commented 3 years ago

Oh i fixed it. Apparently if you dont give replit access to every repl you're meant to have access to on a team, itll refuse to work.