replit / desktop

Replit Desktop App
114 stars 3 forks source link

Set deeplink listeners before app is ready #105

Closed sergeichestakov closed 1 year ago

sergeichestakov commented 1 year ago

Why

Turns out we've been missing deeplink events that cause the app to open (e.g. if you open a deeplink but app is not yet running).

From the docs:

As with the open-file event, be sure to register a listener for the open-url event early in your application startup to detect if the the application being is being opened to handle a URL. If you register the listener in response to a ready event, you'll miss URLs that trigger the launch of your application.

Fixes WS-807

What changed

Set deeplink listeners before app is ready per the docs above

Test plan

Deeplinks that open the app should work (this doesn't work in dev so will have to wait until the next release to properly test)

linear[bot] commented 1 year ago
WS-807 Deeplink not opening properly when app is launched

Think there's a bug with deeplinks where we open the last open Repl instead of the correct page for the deeplink